Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make sender recovery explicit in provider #5776

Merged
merged 2 commits into from
Dec 15, 2023
Merged

refactor: make sender recovery explicit in provider #5776

merged 2 commits into from
Dec 15, 2023

Conversation

onbjerg
Copy link
Collaborator

@onbjerg onbjerg commented Dec 15, 2023

Same as #5771 but for insert_block in the provider

@onbjerg onbjerg added the C-debt A clean up/refactor of existing code label Dec 15, 2023
@onbjerg onbjerg force-pushed the onbjerg/provider-refactor branch from cdda167 to 05f29f3 Compare December 15, 2023 12:40
mattsse
mattsse approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

honestly I'm fine with adding the semicolons, can't be bothered with it anymore

@onbjerg onbjerg added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 3f7760d Dec 15, 2023
@onbjerg onbjerg deleted the onbjerg/provider-refactor branch December 15, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onbjerg @mattsse