Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace std::fs usages with reth-primitives #5813

Merged
merged 1 commit into from
Dec 18, 2023
Merged

refactor: replace std::fs usages with reth-primitives #5813

merged 1 commit into from
Dec 18, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 18, 2023 •
edited
Loading

As per the PR title

@shekhirin shekhirin added the C-debt A clean up/refactor of existing code label Dec 18, 2023
@shekhirin shekhirin changed the title refactor: replace std::fs usages with reth-primitives refactor: replace std::fs usages with reth-primitives Dec 18, 2023
@shekhirin shekhirin marked this pull request as ready for review December 18, 2023 14:59
@shekhirin shekhirin requested a review from mattsse December 18, 2023 15:40
mattsse
mattsse approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit 0e091da Dec 18, 2023
@shekhirin shekhirin deleted the alexey/no-std-fs branch December 18, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse