Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin): disable ETA for execution stage #5839

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 21, 2023

We receive a lot of reports from users who are confused about the ETA for Execution stage, e.g.:

For example, I'm on stage 5 (execution) and have seen the eta be anywhere from 6 hours to 31 days.

The problem is that our ETA works only on two points (previous and current timestamps), and the progress for Execution stage is measured in gas, which is likely not an ideal proxy for real CPU time.

For the time being, I think we should disable the ETA reporting for Execution stage completely, and leave just the percentage progress which should be enough to get the idea of how long it takes to complete.

@shekhirin shekhirin added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) A-observability Related to tracing, metrics, logs and other observability tools labels Dec 21, 2023
@shekhirin shekhirin marked this pull request as ready for review December 21, 2023 13:22
@shekhirin shekhirin requested a review from onbjerg as a code owner December 21, 2023 13:22
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supportive

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable,

can we track readding this once we thought about this a bit more?

@shekhirin
Copy link
Collaborator Author

#5840

@shekhirin shekhirin added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 099c833 Dec 22, 2023
@shekhirin shekhirin deleted the alexey/disable-execution-eta branch December 22, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-staged-sync Related to staged sync (pipelines and stages) C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants