Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use proper decoding types in Header::decode #6046

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: use proper decoding types in Header::decode #6046

merged 1 commit into from
Jan 12, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 12, 2024

This removes .to calls from Header::decode, causing invalid headers to now return a DecodeError when certain fields are too large

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-networking Related to networking in general labels Jan 12, 2024
@Rjected Rjected requested a review from gakonst as a code owner January 12, 2024 19:53
@Rjected Rjected added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit bc229c6 Jan 12, 2024
27 checks passed
@Rjected Rjected deleted the dan/fix-decodable-panics branch January 12, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @gakonst