Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(book): update CLI section #6097

Merged
merged 3 commits into from
Jan 16, 2024
Merged

feat(book): update CLI section #6097

merged 3 commits into from
Jan 16, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jan 16, 2024

make update-book-cli is a blessing

@shekhirin shekhirin added the C-docs An addition or correction to our documentation label Jan 16, 2024
@shekhirin shekhirin marked this pull request as ready for review January 16, 2024 19:44
@shekhirin shekhirin requested a review from gakonst as a code owner January 16, 2024 19:44
@@ -120,7 +132,7 @@ Networking:
Do not persist peers.

--nat <NAT>
NAT resolution method (any|none|upnp|publicip|extip:<IP>)
NAT resolution method (any|none|upnp|publicip|extip:\<IP\>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is from the doc-comments

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@shekhirin shekhirin requested a review from DaniPopes January 16, 2024 20:40
@DaniPopes DaniPopes added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit afa8607 Jan 16, 2024
27 checks passed
@DaniPopes DaniPopes deleted the alexey/update-book branch January 16, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants