feat: add with_unused_ports method to rpc and network args #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
mattsse
approved these changes
Jan 17, 2024
bin/reth/src/args/network_args.rs
Outdated
Comment on lines
128
to
134
| pub fn with_unused_p2p_port(&mut self) { | ||
| self.port = 0; | ||
| } | ||
|
|
||
| /// Sets the p2p and discovery ports to zero, allowing the OD to assign a random unused port | ||
| /// when network components bind to sockets. | ||
| pub fn with_unused_ports(&mut self) { |
There was a problem hiding this comment.
do we want &mut here or self?
we can have two functions if convenient, though the &mut self should also return &mut Self
There was a problem hiding this comment.
changed to mut self -> Self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6107 (comment)
Adds methods on network, discovery, and rpc args for setting ports to zero. This means they will be set to an unused port when bound. This is useful in tests, when many nodes are being spun up at the same time.