Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable tls feature correctly #6120

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: enable tls feature correctly #6120

merged 1 commit into from
Jan 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 18, 2024

Closes #6119

The feature wasn't enabled correctly, and the error masks a tls issue ref hyperium/hyper#1009

This forces rustls which previously wasn't used

 http_client: reqwest::Client::builder().use_rustls_tls().build().unwrap(),
    |                                                     ^^^^^^^^^^^^^^ method not found in `ClientBuilder`

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Jan 18, 2024
@gakonst gakonst enabled auto-merge January 18, 2024 17:00
@gakonst gakonst added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 63adf39 Jan 18, 2024
28 checks passed
@gakonst gakonst deleted the matt/fix-tls-feature branch January 18, 2024 17:16
shekhirin pushed a commit that referenced this pull request Jan 25, 2024
@mattsse @shekhirin
fix: enable tls feature correctly (#6120)
350b23a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst gakonst approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

op-reth eth_sendRawTransaction isn't getting passed to the sequencer URL
3 participants
@mattsse @onbjerg @gakonst