Bug fix, tx fetcher fill_request_for_peer
#6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
emhane
commented
Jan 21, 2024
•
emhane
commented
- Fix bug fill request, check fallback peer before accumulating size
- Extend test to catch fill request bug
- Fix bug tests, assumptions about lru order worked trivially
- Fix bug lru cache, limit reached calculated with limit-1
- Fix bug fill request, include eth66 hash in eth68 request
- Split fill request into 2 methods, one for eth66 and one for eth68 hashes
* Extend test to catch fill request bug * Fix bug tests, assumptions about lru order worked trivially * Fix bug lru cache, limit reached calculated with limit-1
mattsse
added
C-bug
mattsse
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.