fix: ensure tokio rt is always dropped on separate task #6191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we were dropping the tokio runtime on the current task, as described here:
reth/bin/reth/src/runner.rs
Lines 47 to 49 in ffe9691
this causes issues with blocking tasks (pipeline), so in the panic case we did not always exit right away.
This ensures the tokio rt is always dropped on a separate task so we can exit right away.