Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add some notes about tracing #6246

Merged
merged 2 commits into from
Jan 26, 2024
Merged

docs: add some notes about tracing #6246

merged 2 commits into from
Jan 26, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 26, 2024 •
edited
Loading

ref #6240

it looks like the behaviour is not consistent across clients, so unclear atm what to do here.

Added at least some notes, decision tbd

@mattsse mattsse requested a review from Rjected as a code owner January 26, 2024 14:54
@mattsse mattsse added the C-docs An addition or correction to our documentation label Jan 26, 2024
@mattsse mattsse mentioned this pull request Jan 26, 2024
Closed
1 task
Rjected
Rjected approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, these are very useful docs for behavior that is basically unspecified anywhere

looks like some lints are failing because they link to private items

@mattsse mattsse enabled auto-merge January 26, 2024 18:01
@mattsse mattsse added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 30ee746 Jan 26, 2024
28 checks passed
@mattsse mattsse deleted the matt/chore-add-some-notes-about-tracing branch January 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected