add mainnet_activation_timestamp for Hardfork
#6257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jan 28, 2024
Comment on lines
+91
to
+96
| /// Retrieves the activation timestamp for the specified hardfork on the Ethereum mainnet. | ||
| pub fn mainnet_activation_timestamp(&self, chain: Chain) -> Option<u64> { | ||
| if chain != Chain::mainnet() { | ||
| return None; | ||
| } | ||
| match self { |
There was a problem hiding this comment.
lgtm, we could also split these functions into two:
fn activation_timestamp(&self, chain: Chain)
fn mainnet_activation_timestamp(&self)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
mainnet_activation_timestampmethod forHardforkrelated to the following execution layer spec: https://github.com/ethereum/execution-specs/blob/1fed0c0074f9d6aab3861057e1924411948dc50b/src/ethereum_spec_tools/forks.py#L192