Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): RUST_BACKTRACE=1 for all tests #6283

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

shekhirin
Copy link
Collaborator

It will make flaky tests easier to debug:

--- TRY 2 STDERR:        reth-node-core node_config::tests::optimism_post_canyon_withdrawals_valid ---
thread 'tokio-runtime-worker' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytes-1.5.0/src/buf/buf_impl.rs:289:9:
assertion failed: self.remaining() >= 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2024-01-30T10:58:03.134574Z ERROR reth_tasks: Critical task `consensus engine` panicked: `assertion failed: self.remaining() >= 1`
thread 'node_config::tests::optimism_post_canyon_withdrawals_valid' panicked at crates/node-core/src/node_config.rs:1786:13:
post-canyon engine call with withdrawals should succeed: Call(ErrorObject { code: InternalError, message: "Server error", data: Some(RawValue({"err":"beacon consensus engine task stopped"})) })

@shekhirin shekhirin added the A-meta Changes in the contributor workflow and planning label Jan 30, 2024
@shekhirin shekhirin requested a review from mattsse January 30, 2024 11:42
@shekhirin shekhirin added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit add3c6a Jan 30, 2024
28 checks passed
@shekhirin shekhirin deleted the alexey/ci-test-rust-backtrace branch January 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants