chore: Bump revm to newest

[rakita]

Integrate revm to newest branch.

[rkrasiuk]

@rakita merkle scripts do not only verify the correctness of state root calculation, they also verify the correctness of the state. more specifically, i'd recommend running debug execution script since it also checks whether state reverts were written correctly

[rakita]

@rakita merkle scripts do not only verify the correctness of state root calculation, they also verify the correctness of the state. more specifically, i'd recommend running debug execution script since it also checks whether state reverts were written correctly

revm State was not touched and had minimal changes. So revert creation and state change is the same and i didn't felt the need to run it as the fixes that we have were already merged in reth_freeze.

The best test for this change is syncing reth, and this, I already did with Holesky.

[DaniPopes]

Code LGTM

[mattsse]

This is less invasive than expected, I think overall this lgtm, though I'm having some reservations wrt naming.

I'm being particularly pedantic here:

It's a bit challenging to get familiar with the names, takes some time to get used to this for example:

there's EnvWithHandlerCfg and CfgEnvWithHandlerCfg

and HandlerCfg is just the wrapped SpecId, unclear what this has to do with a handler config, besides a feature gated optimism field.
Can we get rid of optimism cfgs eventually by any chance?

there are no docs that cover what the nomenclature is here,
I know they're most likely in the revm mdbook, but this is not very useful, should be directly in the code imo.

the evm type would benefit from some additional helper functions as well

although, I like that we don't have any generics on the handler type, this should make it easier to move this into a config trait

[Rjected]

LGTM!

[Rjected]

there's EnvWithHandlerCfg and CfgEnvWithHandlerCfg

and HandlerCfg is just the wrapped SpecId, unclear what this has to do with a handler config, besides a feature gated optimism field.

Yeah, I found this pretty confusing too, worth considering renames

[Rjected]

oops meant to click "comment" not "close with comment"

[rakita]

About EnvWithHandlerCfg and CfgEnvWithHandlerCfg I want to break those and remove Env soonish (After EOF) with generic tx/block bluealloy/revm#916

I don't especially like these names, but want to have separated HandlerCfg from Env and it came up to this. I would look at them as temporary helpers for transitioning that are going to be modified/removed in few months.

HandlerCfg allowed me to wrap Optimism changes and to have the same behaviour as previously.

[mattsse]

lgtm

ack on EOF

[Rjected]

needs a re review / approve from @emhane i think to merge

completed