Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactoring in payload crate #6358

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Conversation

tcoratger
Copy link
Contributor

No description provided.

Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan of large Ok( blocks, find them less readable

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Feb 2, 2024
@mattsse mattsse enabled auto-merge February 2, 2024 20:04
auto-merge was automatically disabled February 2, 2024 20:05

Head branch was pushed to by a user without write access

@mattsse mattsse enabled auto-merge February 2, 2024 20:08
@mattsse mattsse added this pull request to the merge queue Feb 2, 2024
Merged via the queue into paradigmxyz:main with commit 3dcb04d Feb 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants