Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove chain_spec from ExecutorFactory #6523

Merged
merged 1 commit into from
Feb 10, 2024
Merged

chore: remove chain_spec from ExecutorFactory #6523

merged 1 commit into from
Feb 10, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Feb 10, 2024 •
edited
Loading

The chain_spec method was unused in the ExecutorFactory trait, so I removed it

@Rjected Rjected added C-debt A clean up/refactor of existing code A-engine Related to the engine implementation labels Feb 10, 2024
@DaniPopes DaniPopes added this pull request to the merge queue Feb 10, 2024
Merged via the queue into main with commit 3c3c7b3 Feb 10, 2024
29 checks passed
@DaniPopes DaniPopes deleted the dan/remove-executor-factory-chain-spec branch February 10, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-engine Related to the engine implementation C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @DaniPopes