fix: check versioned hash version for EIP-4844 transactions

[jtraglia]

I didn't see where the versioned hash's version was checked for EIP-4844 transactions. This PR adds this check. I don't believe this is a big deal though because the CL should also check this.

Here's the spec for this:

• https://eips.ethereum.org/EIPS/eip-4844#execution-layer-validation

This part in particular:

# all versioned blob hashes must start with VERSIONED_HASH_VERSION_KZG
for h in tx.blob_versioned_hashes:
    assert h[0] == VERSIONED_HASH_VERSION_KZG

[Rjected]

it should be checked here, although implicitly by recalculating the versioned hash

reth/crates/primitives/src/transaction/eip4844.rs

Lines 147 to 150 in 1cc52ff

	let calculated_versioned_hash = kzg_to_versioned_hash(commitment);
	if *versioned_hash != calculated_versioned_hash {
	return Err(BlobTransactionValidationError::InvalidProof)
	}

the error type is useful though, see the TODO in the above snippet

[jtraglia]

Oh I see, thanks! Would it be worth keeping both checks? How should I proceed?

You're welcome to modify this PR how you see fit btw.

[Rjected]

I think the way forward would be to create a new BlobTransactionValidationError variant that describes a mismatched versioned hash, and change this to return that variant

reth/crates/primitives/src/transaction/eip4844.rs

Line 149 in 1cc52ff

return Err(BlobTransactionValidationError::InvalidProof)

[Rjected]

adding a link to the spec, or even quoting the spec code verbatim around those lines would be useful as an artifact of this

[jtraglia]

Sounds good. I'll make this change tomorrow.

[jtraglia]

Should be ready now!

[Rjected]

awesome, this looks good to me, thanks!