fix the issue of network is not known to be merged

[jsvisa]

close #6453

[jsvisa]

@Rjected PTAL

[mattsse]

hmm, perhaps this is the easiest solution.

but we only need this for displaying, and adding an additional field just for that seems a bit odd, especially if we already have something like this on the Chainspec struct:

reth/crates/primitives/src/chain/spec.rs

Lines 606 to 608 in 6204ec7

	/// The block at which [Hardfork::Paris] was activated and the final difficulty at this block.
	#[serde(skip, default)]
	pub paris_block_and_final_difficulty: Option<(u64, U256)>,

perhaps we use that in DisplayHardforks instead for the None case?
wdyt @Rjected

[mattsse]

Suggested change

	U256::from(58_750_003_716_598_352_816_469_u128),
	U256::from(58_750_003_716_598_352_816_469u128),

[Rjected]

yeah, as I mentioned in the issue, we should be using paris_block_and_total_difficulty

[jsvisa]

yeah, as I mentioned in the issue, we should be using paris_block_and_total_difficulty

@Rjected Sorry, I missed the previous comments. I would like to confirm if I truly understand what you mean, is that correct? We can pass paris_block_and_total_difficulty to DisplayHardforks::new, something like below:

impl DisplayHardforks {
    /// Creates a new [`DisplayHardforks`] from an iterator of hardforks.
    pub fn new(hardforks: &BTreeMap<Hardfork, ForkCondition>, ttd: U256) -> Self {
        Self::from_iter(hardforks.iter().map(|(fork, condition)| (fork, condition, ttd)))
    }
}

impl<'a, 'b> FromIterator<(&'a Hardfork, &'b ForkCondition)> for DisplayHardforks {
    fn from_iter<T: IntoIterator<Item = (&'a Hardfork, &'b ForkCondition, U256)>>(iter: T) -> Self {
        let mut pre_merge = Vec::new();
        let mut with_merge = Vec::new();
        let mut post_merge = Vec::new();

        for (fork, condition, ttd) in iter {
            let display_fork =
                DisplayFork { name: fork.to_string(), activated_at: *condition, eip: None, ttd };

            match condition {
                ForkCondition::Block(_) => {
                    pre_merge.push(display_fork);
                }
                ForkCondition::TTD { .. } => {
                    with_merge.push(display_fork);
                }
                ForkCondition::Timestamp(_) => {
                    post_merge.push(display_fork);
                }
                ForkCondition::Never => continue,
            }
        }

        Self { pre_merge, with_merge, post_merge }
    }
}

[mattsse]

yeah, we can remove the from iter impl, and add known_paris_block: Option<u64> to that

and we can add displayforks(&self) function to the chainspec type

[jsvisa]

@mattsse thanks for the advice, adjusted, and PTAL

[mattsse]

lgtm

pending @Rjected + lint fixes

[Rjected]

this looks good to me, thanks!