fix(op): use canyon,ecotone fork timestamps for op mainnet #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
joshieDo
approved these changes
Apr 30, 2024
onbjerg
approved these changes
May 1, 2024
There was a problem hiding this comment.
can we get a smol test ala
reth/crates/primitives/src/chain/spec.rs
Lines 2414 to 2416 in 3d28a69
but for op mainnet? doesn't need to be exhaustive
Rjected
force-pushed
the
dan/fix-op-mainnet-forkid
branch
from
3d28a69 to
6d0b2a0
Compare
just added a basic test, will modify #8012 to make it clear that the test just needs to be completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the op mainnet forkid, by adding the canyon and ecotone fork timestamps to the op mainnet chainspec.