Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pruner): set default timeout to None on PrunerBuilder #8181

Merged
merged 1 commit into from
May 9, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented May 9, 2024

As discussed on: #8127 (comment)

From what I could check, node builder overrides it already anyway.

pub fn pruner_builder(&self) -> PrunerBuilder {
PrunerBuilder::new(self.prune_config().unwrap_or_default())
.prune_delete_limit(self.chain_spec().prune_delete_limit)
.timeout(PrunerBuilder::DEFAULT_TIMEOUT)
}

There are scenarios such reth stage unwind that shouldn't have a timeout.

@joshieDo joshieDo added the A-pruning Related to pruning or full node label May 9, 2024
@joshieDo joshieDo requested a review from shekhirin as a code owner May 9, 2024 16:27
@joshieDo joshieDo requested a review from emhane May 9, 2024 16:27
@joshieDo joshieDo added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 4bbc850 May 9, 2024
29 checks passed
@joshieDo joshieDo deleted the joshie/pruner-timeout branch May 9, 2024 16:56
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants