feat: reset trie updates on make_canonical #8370
Conversation
fgimenez
added
A-engine
fgimenez
requested review from
rakita,
joshieDo,
shekhirin and
rkrasiuk
as code owners
| .filter_map(|child| self.block_indices().get_blocks_chain_id(&child)) | ||
| .collect(); |
There was a problem hiding this comment.
ah we need this collect because this resides in state and the compiler doesn't allow us to borrow here.
maybe we could move this to a function in state
There was a problem hiding this comment.
@mattsse exactly, with a for_each after the filter_map the second closure (in for_each) required exclusive access to self.state.chains but was already borrowed in the first closure (filter_map) due to the use of *self.
Not sure if moving the code to a function in state could help, the first part (determining the dependent blocks that extend the old tip and their chain ids) is done using the indices, not the state, and the second one (querying the chains associated with each chain id) is done using the state, maybe I'm missing something?
I've pushed changes to prevent creating the temporary vector using nested if lets, ptal.
Reset trie updates for the rest of the children forking from the canonical tip after a fork choice update.