fix(engine): do not ignore provider errors #8519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-debt
|
pre-emptive hive run in case i missed smth |
rkrasiuk
commented
May 30, 2024
| ) -> ProviderResult<Option<B256>> { | ||
| // Check if parent exists in side chain or in canonical chain. | ||
| if self.blockchain.find_block_by_hash(parent_hash, BlockSource::Any)?.is_some() { | ||
| return Ok(Some(parent_hash)) | ||
| } |
There was a problem hiding this comment.
insert_err was present only during single invocation, the check was moved there
mattsse
approved these changes
May 30, 2024
DaniPopes
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a couple of provider lookups which ignore potentially critical errors. Fix that by always propagating provider errors.