example(exex): tests for In Memory State #8682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/exex-in-memory-state-test
branch
from
72b2afe to
1837819
Compare
shekhirin
force-pushed
the
alexey/exex-in-memory-state-test
branch
from
1837819 to
b9fde18
Compare
gakonst
reviewed
Jun 7, 2024
Comment on lines
+32
to
+49
| fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
| let this = self.get_mut(); | ||
|
|
||
| while let Some(notification) = ready!(this.ctx.notifications.poll_recv(cx)) { | ||
| match ¬ification { | ||
| ExExNotification::ChainCommitted { new } => { | ||
| info!(committed_chain = ?new.range(), "Received commit"); | ||
| } | ||
| ExExNotification::ChainReorged { old, new } => { | ||
| // revert to block before the reorg | ||
| this.state.revert_to(new.first().number - 1); | ||
| info!(from_chain = ?old.range(), to_chain = ?new.range(), "Received reorg"); | ||
| } | ||
| ExExNotification::ChainReverted { old } => { | ||
| this.state.revert_to(old.first().number - 1); | ||
| info!(reverted_chain = ?old.range(), "Received revert"); | ||
| } | ||
| }; |
There was a problem hiding this comment.
in this case we should also explain a nice UX for how you'd call async functions inside the future loop?
There was a problem hiding this comment.
yeah, but I'm still unsure what's the best approach here. So I think we should merge this PR first as it's about the testing, and then mention what you said in the book.
mattsse
approved these changes
Jun 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shekhirin
force-pushed
the
alexey/exex-in-memory-state-test
branch
from
825e128 to
6d2ec02
Compare
shekhirin
force-pushed
the
alexey/exex-in-memory-state-test
branch
from
6d2ec02 to
ecc565f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the "In Memory State" ExEx example, showing how you can assert the internal state of the ExEx. It requires implementing the
Futuremanually, so that you still could access the struct after polling it.