Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): EthBlocks default impl #8723

Merged
merged 67 commits into from
Jun 11, 2024
Merged

chore(rpc): EthBlocks default impl #8723

merged 67 commits into from
Jun 11, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jun 10, 2024 •
edited
Loading

  • Moves blocks eth_ RPC methods to default trait methods of EthBlocks, reusable for any network
  • Moves remaining transaction RPC methods using LoadBlock, into EthTransactions default impl
  • Rounds of creation of traits to read data from db, prefixed Load, by updating docs

emhane added 30 commits June 1, 2024 12:18
@emhane
Make on_blocking_task method accessible in default trait method impls
cab888f
@emhane
Minimise thread interface eth api
b902f35
@emhane
Update docs and symbol name
c35b40e
@emhane
Add missing reth primitives to op feature
8ccddd3
@emhane
Remove feature gate to fix broken test
257dc5d
@emhane
Fix flaky test
40194d6
@emhane
fixup! Fix flaky test
68e64b4
@emhane
fixup! Fix flaky test
30b63cc
@emhane
Update lock file
fcc64ea
@emhane
Reinsert functions for spawning blocking threads into EthTransactions
734ac99
@emhane
Drive-by, update docs
c000f43
@emhane
Move spawn cpu heavy to trait
d1b91ad
@emhane
Fix lint
eec99b8
@emhane
Revert impl for spawning blocking io
924024f
@emhane
Make impl of spawn blocking default trait methods
ea6cbd3
@emhane
Update docs
ecb6771
@emhane
Revert unrelated changes
fe494dc
@emhane
Merge branch 'main' into emhane/blocking-read
ba6f403
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/blocking-read
55d2649
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/blocking-read
139f97f
@emhane
Fix lint
8b8ed16
@emhane
Add super traits to spawn blocking
f3ed6bd
@emhane
Move impl of methods using evm config to default trait methods
16334cd
@emhane
Move EthApi state access methods into trait
20d2489
@emhane
Move EthTransaction impls to default trait methods
4a40032
@emhane
Move state rpc methods into new trait default impl
f2df915
@emhane
fixup! Move state rpc methods into new trait default impl
ca19811
@emhane
Move EthTransactions impl to default trait methods
8ee373c
@emhane
Add trait for pending block
6dfac1a
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/ethapi-txns
90f67b6
@emhane emhane added the S-blocked This cannot more forward until something else changes label Jun 10, 2024
@emhane emhane changed the base branch from main to emhane/ethapi-call June 10, 2024 14:24
@emhane emhane requested a review from onbjerg as a code owner June 10, 2024 14:24
Base automatically changed from emhane/ethapi-call to matt/scaffold-ethapi June 11, 2024 16:25
@emhane emhane merged commit 197b182 into matt/scaffold-ethapi Jun 11, 2024
20 of 26 checks passed
@emhane emhane deleted the emhane/ethapi-blocks branch June 11, 2024 18:07
@emhane emhane mentioned this pull request Jun 12, 2024
Closed
emhane added a commit that referenced this pull request Jun 13, 2024
@emhane
chore(rpc): EthBlocks default impl (#8723)
a37d044
@emhane emhane mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@rakita rakita Awaiting requested review from rakita

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse