-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add start_time
to ProcessUID
on StorageLock
#8753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work
Calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pedantic suggestions
crates/storage/db/Cargo.toml
Outdated
@@ -78,6 +78,7 @@ mdbx = ["reth-libmdbx"] | |||
bench = [] | |||
arbitrary = ["reth-primitives/arbitrary", "reth-db-api/arbitrary"] | |||
optimism = [] | |||
disable_lock = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this feature enabled do we then need sysinfo dep?
opting out is a lot harder than opting in, but in this case we expect that this is only disabled for testing, so imo this is fine
Makes the identifier more unique by adding
start_time
.Fixes the following kind of issue:
reth node
with PID 9 locks storage.reth node
stops non-gracefully leaving the lockfiles behind.firefox
starts with PID 9.reth node
attempts to start but realizes that PID 9 is executing, and thus, does not acquire the lock.