Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce payload types #8756

Merged
merged 6 commits into from Jun 11, 2024
Merged

feat: introduce payload types #8756

merged 6 commits into from Jun 11, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2024

Ref #8330

@ghost ghost requested review from mattsse, Rjected, fgimenez, rkrasiuk and gakonst as code owners June 11, 2024 16:51
mattsse
mattsse requested changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

smol nit,

I want to merge this pr like this, and we replace the payloadbuilder trait bounds in a followup

@mattsse mattsse added C-enhancement New feature or request A-block-building Related to block building labels Jun 11, 2024
@ghost ghost requested a review from onbjerg as a code owner June 11, 2024 19:40
@ghost ghost requested a review from mattsse June 11, 2024 20:18
mattsse
mattsse approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, nextup payload crate 🫡

@mattsse mattsse enabled auto-merge June 11, 2024 20:34
@mattsse mattsse added this pull request to the merge queue Jun 11, 2024
Merged via the queue into paradigmxyz:main with commit 268e768 Jun 11, 2024
29 checks passed
@ghost ghost deleted the introduce-payloadtypes branch June 11, 2024 21:19
emhane pushed a commit that referenced this pull request Jun 13, 2024
@mattsse @emhane
feat: introduce payload types (#8756)
94c09dc 
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-block-building Related to block building C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattsse