fix: ensure that a new offset file ends with the zero data file length #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-bug
mattsse
approved these changes
Jun 12, 2024
shekhirin
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last offset is always the expected data file length. However, on creation this value wasn't being written. This is not an issue for a read-write environment since it will always recover, and that's why it wasn't caught until #8667 made it through.
Without it,
NippyJarError::InconsistentStatewill be thrown on a read-only environment if the segment is empty. For example,reth db statson a newly created datadir, will throw this error on Transaction segmentAlso, makes sure we only write if the file is just created, and not always as it was before.