-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support no_std
for reth-primitives
#8817
Merged
mattsse
merged 8 commits into
paradigmxyz:main
from
JackG-eth:feature_this_error_no_std_rp
Jun 17, 2024
Merged
feat: support no_std
for reth-primitives
#8817
mattsse
merged 8 commits into
paradigmxyz:main
from
JackG-eth:feature_this_error_no_std_rp
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might be a couple of Nits here, a lot more has changed @mattsse |
DaniPopes
requested changes
Jun 14, 2024
mattsse
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just extracted a lot of stuff, sorry about the conflicts -.-
09fb290
to
801b529
Compare
…_this_error_no_std_rp
This Is WIP after rebasing.. |
This should be good now, both builds work with conflicts resolved. |
mattsse
approved these changes
Jun 15, 2024
081d559
to
d7ce860
Compare
onbjerg
approved these changes
Jun 17, 2024
DaniPopes
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #8708
closes #5746