Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support no_std for reth-primitives #8817

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

JackG-eth
Copy link
Contributor

@JackG-eth JackG-eth commented Jun 13, 2024

Motivation
closes #8708
closes #5746

@JackG-eth
Copy link
Contributor Author

Might be a couple of Nits here, a lot more has changed @mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just extracted a lot of stuff, sorry about the conflicts -.-

@JackG-eth JackG-eth force-pushed the feature_this_error_no_std_rp branch from 09fb290 to 801b529 Compare June 14, 2024 14:11
@JackG-eth JackG-eth requested a review from rkrasiuk as a code owner June 14, 2024 14:11
@JackG-eth
Copy link
Contributor Author

This Is WIP after rebasing..

@JackG-eth
Copy link
Contributor Author

This should be good now, both builds work with conflicts resolved.

@mattsse mattsse enabled auto-merge June 15, 2024 17:22
@mattsse mattsse added the C-enhancement New feature or request label Jun 15, 2024
@mattsse mattsse force-pushed the feature_this_error_no_std_rp branch from 081d559 to d7ce860 Compare June 15, 2024 17:24
@onbjerg onbjerg requested a review from DaniPopes June 17, 2024 06:26
@mattsse mattsse added this pull request to the merge queue Jun 17, 2024
Merged via the queue into paradigmxyz:main with commit 8d54f2f Jun 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reth-primitives no-std support Split reth-primitives and support no_std compilation.
4 participants