Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exex): derive serde ser/deser for ExExNotification #8963

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat(exex): derive serde ser/deser for ExExNotification #8963

merged 2 commits into from
Jun 20, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jun 19, 2024 •
edited
Loading

Derives serde::{Serialize, Deserialize} for the ExExNotification and all downstream types.

@shekhirin shekhirin added A-exex Execution Extensions C-enhancement New feature or request labels Jun 19, 2024
@shekhirin shekhirin marked this pull request as ready for review June 19, 2024 17:50
@shekhirin shekhirin force-pushed the alexey/serde-derives branch from 7861330 to 8deaea4 Compare June 19, 2024 17:58
mattsse
mattsse requested changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo adding support for serialize makes sense given the direction we want to take this.

can we rename everything to camelCase ?

@DaniPopes
Copy link
Member

No, this is rust 👍

@mattsse
Copy link
Collaborator

mattsse commented Jun 19, 2024

i meant via serde :)

@DaniPopes
Copy link
Member

Yes, I mean that too

@shekhirin
Copy link
Collaborator Author

imo adding support for serialize makes sense given the direction we want to take this.

can we rename everything to camelCase ?

I don't think we should do it for two reasons:

  1. We have a separate layer of RPC compatibility where we do camelCase
  2. We already had a lot of ser/deser implementations for primitive types, and didn't use camelCase there

@shekhirin shekhirin added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 554e8b1 Jun 20, 2024
31 checks passed
@shekhirin shekhirin deleted the alexey/serde-derives branch June 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@emhane emhane Awaiting requested review from emhane

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @DaniPopes @mattsse