Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add engine tree test, FCU triggers reorg with all the blocks present #9943

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Jul 31, 2024

Towards #9749

The test raised the lack of some events not being emitted, they are added now to EngineApiTreeHandlerImpl: EngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::ForkBlockAdded), EngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::CanonicalBlockAdded) and EngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::CanonicalChainCommitted).

Besides the test and the changes above, the PR also includes:

  • Changes in TestBlockBuilder to get the execution outcome of a given block
  • Changes in MockEthProvider to include a state root store, and use it in the StateRootProvider impl methods.

@fgimenez fgimenez added C-test A change that impacts how or what we test C-enhancement New feature or request labels Aug 1, 2024
@fgimenez fgimenez force-pushed the fgimenez/engine-tree-tests-fcu-reorg-with-all-blocks branch from 37415bf to 4a4574f Compare August 1, 2024 09:16
@fgimenez fgimenez marked this pull request as ready for review August 1, 2024 09:21
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean!

@fgimenez fgimenez added this pull request to the merge queue Aug 1, 2024
@fgimenez fgimenez removed this pull request from the merge queue due to a manual request Aug 1, 2024
@fgimenez fgimenez force-pushed the fgimenez/engine-tree-tests-fcu-reorg-with-all-blocks branch from 750b84c to 9b20bcf Compare August 1, 2024 15:05
@fgimenez
Copy link
Member Author

fgimenez commented Aug 1, 2024

I've added a new test that exercises extending the canonical chain and expecting CanonicalBlockAdded events and this showed some issues in is_fork method, should be fixed now

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@fgimenez fgimenez enabled auto-merge August 1, 2024 15:18
@fgimenez fgimenez added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 0a1be8c Aug 1, 2024
32 checks passed
@fgimenez fgimenez deleted the fgimenez/engine-tree-tests-fcu-reorg-with-all-blocks branch August 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants