-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add engine tree test, FCU triggers reorg with all the blocks present #9943
test: add engine tree test, FCU triggers reorg with all the blocks present #9943
Conversation
37415bf
to
4a4574f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very clean!
750b84c
to
9b20bcf
Compare
I've added a new test that exercises extending the canonical chain and expecting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Towards #9749
The test raised the lack of some events not being emitted, they are added now to
EngineApiTreeHandlerImpl
:EngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::ForkBlockAdded)
,EngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::CanonicalBlockAdded)
andEngineApiEvent::BeaconConsensus(BeaconConsensusEngineEvent::CanonicalChainCommitted)
.Besides the test and the changes above, the PR also includes:
TestBlockBuilder
to get the execution outcome of a given blockMockEthProvider
to include a state root store, and use it in theStateRootProvider
impl methods.