Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: Fix double lock and state overwrite on disconnected peers #179

Merged
merged 12 commits into from
Aug 2, 2024
+257 −54
Merged

transport: Fix double lock and state overwrite on disconnected peers #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c6f4191
transport: Fix double lock and state overwrite on disconnected peers
lexnv Jul 17, 2024
c54c0c8
transport: Warn missmatching dial failures wrt connection IDs
lexnv Jul 17, 2024
3461347
transport: Update address score accordingly on on_dial_failure
lexnv Jul 17, 2024
f902a78
transport: Track dial addresses
lexnv Jul 17, 2024
0c4aa51
transport/tests: Ensure multiple dials do not overwrite the current dial
lexnv Jul 17, 2024
9a804a7
transport: Saturating add
lexnv Jul 17, 2024
68bb679
transport: Extend todo with more information for separate PR
lexnv Jul 17, 2024
daa147b
transport/tests: Backport test from PR #176
lexnv Jul 17, 2024
062ed6d
transport/manager: Update comment with link to issue
lexnv Aug 2, 2024
07d516b
Merge remote-tracking branch 'origin/master' into lexnv/transport-man…
lexnv Aug 2, 2024
e659baf
transport/tests: Reject secondary unknown from theoretical state
lexnv Aug 2, 2024
adc4657
transport/manager: Remove debug_asserts
lexnv Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transport/manager/address.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ impl AddressRecord {

/// Update score of an address.
pub fn update_score(&mut self, score: i32) {
self.score += score;
self.score = self.score.saturating_add(score);
}

/// Set `ConnectionId` for the [`AddressRecord`].
Expand Down
Loading