parity-crypto: remove UB test (#484)

* parity-crypto: remove UB test * rlp: fix unused import
paritytech · Dec 28, 2020 · 6560949 · 6560949
1 parent da4262d
commit 6560949
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 20 deletions.
diff --git a/parity-crypto/src/hmac/test.rs b/parity-crypto/src/hmac/test.rs
@@ -232,21 +232,3 @@ fn ietf_test_vectors() {
 		),
 	);
 }
-
-#[test]
-fn secrets_are_zeroed_on_drop() {
-	let ptr: *const KeyInner;
-	let zeros = KeyInner::Sha256(DisposableBox::from_slice(&[0u8; 6][..]));
-	let expected = KeyInner::Sha256(DisposableBox::from_slice(b"sikrit"));
-	{
-		let secret = b"sikrit";
-		let signing_key = SigKey::sha256(secret);
-		ptr = &signing_key.0;
-		unsafe {
-			assert_eq!(*ptr, expected);
-		}
-	}
-	unsafe {
-		assert_eq!(*ptr, zeros);
-	}
-}
diff --git a/rlp/src/traits.rs b/rlp/src/traits.rs
@@ -7,8 +7,6 @@
 // except according to those terms.
 
 //! Common RLP traits
-#[cfg(not(feature = "std"))]
-use alloc::vec::Vec;
 use bytes::BytesMut;
 
 use crate::{error::DecoderError, rlpin::Rlp, stream::RlpStream};