Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running subsystem-benchmarks with nextest #3716

Closed
wants to merge 1 commit into from
Closed

Avoid running subsystem-benchmarks with nextest #3716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions polkadot/node/network/availability-recovery/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ required-features = ["subsystem-benchmarks"]

[features]
subsystem-benchmarks = []
subsystem-benchmarks-helpers = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsystem-benchmarks feature seems to no longer be used at all.

Copy link
Contributor Author

@AndreiEres AndreiEres Mar 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in use. We require that feature to run regression tests. That way we don't mix normal and regression tests.

https://github.com/paritytech/polkadot-sdk/pull/3716/files#diff-ccb20ed2e9c6555ef9cd2b6e0905839764e8eac5da8970f170957da9cc9efc8fR46-R50

2 changes: 1 addition & 1 deletion polkadot/node/network/availability-recovery/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ async fn erasure_task_thread(

// In benchmarks this is a very hot loop not yielding at all.
// To update CPU metrics for the task we need to yield.
#[cfg(feature = "subsystem-benchmarks")]
#[cfg(feature = "subsystem-benchmarks-helpers")]
tokio::task::yield_now().await;
}
}
2 changes: 1 addition & 1 deletion polkadot/node/subsystem-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ polkadot-node-subsystem-types = { path = "../subsystem-types" }
polkadot-node-primitives = { path = "../primitives" }
polkadot-primitives = { path = "../../primitives" }
polkadot-node-network-protocol = { path = "../network/protocol" }
polkadot-availability-recovery = { path = "../network/availability-recovery", features = ["subsystem-benchmarks"] }
polkadot-availability-recovery = { path = "../network/availability-recovery", features = ["subsystem-benchmarks-helpers"] }
polkadot-availability-distribution = { path = "../network/availability-distribution" }
polkadot-node-core-av-store = { path = "../core/av-store" }
polkadot-node-core-chain-api = { path = "../core/chain-api" }
Expand Down
Loading