Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump lookahead to 3 for testnet genesis #7252

Merged
merged 4 commits into from
Jan 23, 2025
Merged

bump lookahead to 3 for testnet genesis #7252

merged 4 commits into from
Jan 23, 2025

Conversation

alindima
Copy link
Contributor

This is the right value after #4880, which corresponds to an allowedAncestryLen of 2 (which is the default)

WIll fix #7105

@alindima alindima added the T10-tests This PR/Issue is related to tests. label Jan 20, 2025
@alindima alindima mentioned this pull request Jan 20, 2025
Closed
bkchr
bkchr previously requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still for fixing this properly: #7105 (comment)

@bkchr bkchr dismissed their stale review January 21, 2025 10:10

Still not happy with it, but okay..

@bkchr bkchr enabled auto-merge January 21, 2025 10:10
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jan 21, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12926269008
Failed job name: cargo-clippy

@bkchr bkchr added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit cfc5b6f Jan 23, 2025
161 of 204 checks passed
@bkchr bkchr deleted the alindima/bump-lookahead branch January 23, 2025 13:36
@tdimitrov tdimitrov mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@tdimitrov tdimitrov tdimitrov approved these changes

@sandreim sandreim sandreim approved these changes

@bkchr bkchr bkchr left review comments

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test zombienet-cumulus-0005-migrate_solo_to_para
5 participants
@alindima @pepoviola @tdimitrov @bkchr @sandreim