Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs feature #116

Merged
merged 12 commits into from
Jul 22, 2021
Merged

Improve docs feature #116

merged 12 commits into from
Jul 22, 2021

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Jul 19, 2021 •
edited
Loading

Closes #109

  1. Clean up doc attribute literal parsing.
  2. Use builder with #[inline] no-ops to prevent doc capture, the compiler should optimize away the static strings.
  3. docs is now an opt-in (non default) feature

/cc @jacogr

@ascjones ascjones merged commit eb28e12 into master Jul 22, 2021
@ascjones ascjones deleted the aj-improve-docs branch July 22, 2021 12:06
@ascjones ascjones mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve docs feature
2 participants
@ascjones @Robbepop