Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-conviction-voting: make the pallet instantiable #11088

Merged
merged 2 commits into from
Mar 25, 2022
Merged

pallet-conviction-voting: make the pallet instantiable #11088

merged 2 commits into from
Mar 25, 2022

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Mar 22, 2022

Signed-off-by: koushiro [email protected]

related issue: #11056

polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK

@koushiro koushiro changed the title pallet-conviction-voting: make the pallet instanceable pallet-conviction-voting: make the pallet instantiable Mar 22, 2022
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 22, 2022
@shawntabrizi
Copy link
Member

/tip medium

this will cover both this pr and #11089

@substrate-tip-bot
Copy link

Please fix the following problems before calling the tip bot again:

  • Invalid command! Payload should be: "/tip { small / medium / large }".

@shawntabrizi
Copy link
Member

/tip medium

@substrate-tip-bot
Copy link

A medium tip was successfully submitted for koushiro (15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lil bit confused about how the types aliases works, there might be a mistake there.

@KiChjang
Copy link
Contributor

bot merge

@shawntabrizi shawntabrizi merged commit 318dea3 into paritytech:master Mar 25, 2022
@koushiro koushiro deleted the conviction-voting-instance branch March 25, 2022 15:21
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
)

* pallet-conviction-voting: make the pallet instanceable

Signed-off-by: koushiro <[email protected]>

* Add default type param for some type alias

Signed-off-by: koushiro <[email protected]>
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
)

* pallet-conviction-voting: make the pallet instanceable

Signed-off-by: koushiro <[email protected]>

* Add default type param for some type alias

Signed-off-by: koushiro <[email protected]>
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
)

* pallet-conviction-voting: make the pallet instanceable

Signed-off-by: koushiro <[email protected]>

* Add default type param for some type alias

Signed-off-by: koushiro <[email protected]>
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
)

* pallet-conviction-voting: make the pallet instanceable

Signed-off-by: koushiro <[email protected]>

* Add default type param for some type alias

Signed-off-by: koushiro <[email protected]>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
)

* pallet-conviction-voting: make the pallet instanceable

Signed-off-by: koushiro <[email protected]>

* Add default type param for some type alias

Signed-off-by: koushiro <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants