This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
RPC: Block number to block hash #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
previously approved these changes
Aug 20, 2018
gavofyork
added
A8-looksgood
and removed
A0-please_review
gavofyork
previously approved these changes
Aug 20, 2018
arkpar
reviewed
Aug 21, 2018
| @@ -40,20 +40,22 @@ use self::error::Result; | |||
|
|
|||
| build_rpc_trait! { | |||
| /// Polkadot blockchain API | |||
| pub trait ChainApi<Hash, Header, Extrinsic> { | |||
| pub trait ChainApi<Hash, Header, Number, Extrinsic> { | |||
There was a problem hiding this comment.
Why not just use Header::Number?
There was a problem hiding this comment.
We can't specify bounds in build_rpc_trait macro.
tomusdrw
added
A0-please_review
arkpar
added
A8-looksgood
and removed
A0-please_review
arkpar
approved these changes
Aug 23, 2018
dvdplm
added a commit
that referenced
this pull request
Aug 27, 2018
…and-rlpcodec * master: Contract signatures checking (#478) extrinsic-pool: use retain() (#613) rename Polkadot to Substrate in the license header via following four commands (#614) typo fixes (#608) RPC: Block number to block hash (#584) Minor fixes for nightly 2018-08-18 (#600) Time-based transaction banning (#594) (#602) cargo --force to allow CI to build. (#599) Fix logging (#587) Fix runtime version cache (#586)
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
reject more than 1/3, related to https://github.com/chainpool/ChainX/issues/571 all tx inputs sig count should same apply_create_withdraw support check sign same time fix https://github.com/chainpool/ChainX/issues/570 fix https://github.com/chainpool/ChainX/issues/546 fix https://github.com/chainpool/ChainX/issues/578 fix std print addr in runtime fix withdraw list tx state fix https://github.com/chainpool/ChainX/issues/575
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed other
chain_methods to have optional hash parameter (by default they return latest header/block/hash).This caused
chain_getHeadmethod to become equivalent withchain_blockHashmethod, so I made it an alias for now.