Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove Release assets #1741

Closed
wants to merge 3 commits into from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 28, 2023

New Pull Request Checklist

Issue Description

Removes release assets from release

Closes: #1740

Approach

  • Remove assets from CI
  • Update README instructions

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 28, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis dplewis requested a review from mtrezza September 28, 2023 16:58
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7231bf7) 78.23% compared to head (42a0f02) 64.43%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1741       +/-   ##
===========================================
- Coverage   78.23%   64.43%   -13.81%     
===========================================
  Files         307      200      -107     
  Lines       36981    23177    -13804     
===========================================
- Hits        28931    14933    -13998     
- Misses       8050     8244      +194     

see 124 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis
Copy link
Member Author

dplewis commented Sep 30, 2023

@mtrezza this is ready for review

@mtrezza
Copy link
Member

mtrezza commented Oct 1, 2023

I seem to remember that we recently did not have assets in releases and there was someone requesting they'd be added. I'm not sure about the use cases for these assets. Any good reason someone would need to add the SDK as a file directly to a Xcode project instead of using SPM?

@dplewis
Copy link
Member Author

dplewis commented Oct 3, 2023

I seem to remember that we recently did not have assets in releases

Assets have been available since the beginning of the SDK.

Any good reason someone would need to add the SDK as a file directly

I'm also not sure about the use cases for these assets unless they can't get SPM to work. @parse-community/ios-sdk any idea?

@mtrezza
Copy link
Member

mtrezza commented Oct 3, 2023

Assets have been available since the beginning of the SDK.

They haven't been available at some point, I believe with the introduction with SPM. We even have added a manual CI workflow to add the assets in case the process fails. I remember there was a complaint, but I can't find it.

@mtrezza
Copy link
Member

mtrezza commented Oct 3, 2023

Let's leave this open for some days and the go ahead and remove them, I'd suggest.

@dplewis
Copy link
Member Author

dplewis commented Oct 4, 2023

@mtrezza A use case is if you need to develop using an offline or static framework.

@mtrezza mtrezza mentioned this pull request Oct 4, 2023
9 tasks
@mtrezza
Copy link
Member

mtrezza commented Oct 4, 2023

I'm continuing the discussion in #1740 (comment), because it's not PR related.

@dplewis dplewis closed this Oct 4, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 5, 2023

@dplewis I notice that this PR contains some changes to the README that are missing in #1744. Is this PR still useful?

@dplewis
Copy link
Member Author

dplewis commented Oct 5, 2023

I’ll create another PR as there maybe merge conflicts. This PR is useful because it removes publishing the assets to GitHub on version release

@dplewis dplewis deleted the remove-release-assets branch October 5, 2023 03:42
@mtrezza
Copy link
Member

mtrezza commented Oct 5, 2023

Other PR: #1745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove alternative install options
2 participants