-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove Release assets #1741
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
===========================================
- Coverage 78.23% 64.43% -13.81%
===========================================
Files 307 200 -107
Lines 36981 23177 -13804
===========================================
- Hits 28931 14933 -13998
- Misses 8050 8244 +194 ☔ View full report in Codecov by Sentry. |
@mtrezza this is ready for review |
I seem to remember that we recently did not have assets in releases and there was someone requesting they'd be added. I'm not sure about the use cases for these assets. Any good reason someone would need to add the SDK as a file directly to a Xcode project instead of using SPM? |
Assets have been available since the beginning of the SDK.
I'm also not sure about the use cases for these assets unless they can't get SPM to work. @parse-community/ios-sdk any idea? |
They haven't been available at some point, I believe with the introduction with SPM. We even have added a manual CI workflow to add the assets in case the process fails. I remember there was a complaint, but I can't find it. |
Let's leave this open for some days and the go ahead and remove them, I'd suggest. |
@mtrezza A use case is if you need to develop using an offline or static framework. |
I'm continuing the discussion in #1740 (comment), because it's not PR related. |
I’ll create another PR as there maybe merge conflicts. This PR is useful because it removes publishing the assets to GitHub on version release |
Other PR: #1745 |
New Pull Request Checklist
Issue Description
Removes release assets from release
Closes: #1740
Approach
TODOs before merging