Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role based authorization #417

Merged
merged 12 commits into from
May 24, 2023
Merged

Add role based authorization #417

merged 12 commits into from
May 24, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented May 20, 2023 •
edited by nitisht
Loading

Part of #250

@nitisht nitisht marked this pull request as ready for review May 22, 2023 07:04
@nitisht nitisht self-requested a review May 22, 2023 07:04
nitisht
nitisht requested changes May 22, 2023
View reviewed changes
nitisht
nitisht requested changes May 22, 2023
View reviewed changes
@nitisht
Copy link
Member

nitisht commented May 22, 2023

Issues in testing

  1. {{endpoint}}/api/v1/logstream/{{stream_name}} succeeds for a user with reader role.
  2. Need to add a list users API - GET {{endpoint}}/api/v1/user.

@trueleo
Copy link
Contributor Author

trueleo commented May 22, 2023

{{endpoint}}/api/v1/logstream/{{stream_name}} succeeds for a user with reader role.

Fixed

@nitisht nitisht mentioned this pull request May 23, 2023
Merged
nitisht
nitisht approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Tested

@nitisht nitisht merged commit ae5ee15 into parseablehq:main May 24, 2023
@nitisht nitisht mentioned this pull request May 24, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trueleo @nitisht