Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuple fix #717

Merged
merged 2 commits into from
May 11, 2024
Merged

tuple fix #717

merged 2 commits into from
May 11, 2024

Conversation

lockwo
Copy link
Contributor

@lockwo lockwo commented May 8, 2024

Fixes #715

@lockwo
Copy link
Contributor Author

lockwo commented May 8, 2024

The tests will fail, but there's some issues that are unrelated: #716

Copy link
Owner

@patrick-kidger patrick-kidger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, awesome! Thank you for taking this on. I'm glad to see this doesn't look too tricky!

@lockwo lockwo requested a review from patrick-kidger May 10, 2024 18:28
@patrick-kidger
Copy link
Owner

LGTM! Thank you for the fix here.

Indeed the latest JAX release broke some stuff, so in the meantime I'm going to merge this anyway.

@patrick-kidger patrick-kidger merged commit 35d7454 into patrick-kidger:main May 11, 2024
0 of 2 checks passed
@lockwo lockwo deleted the Owen/tuple-fix branch September 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange error with multiple tuples as attributes and equinox.tree_at?
2 participants