Preserve exceptions raised by a wrapped python fileobj #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the cause of the ZranError raised by IndexedGzipFile, instead of discarding it. The original exception can contain important information, and with this it will be included in the traceback.
|
Hi @camillol, thanks - this sounds like a good idea. I'll have a closer look tomorrow, and should be able to get a new release out by the end of the week. |
|
Great, thank you!!
…On Tue, Nov 12, 2024 at 00:59 Paul McCarthy ***@***.***> wrote:
Hi @camillol <https://github.com/camillol>, thanks - this sounds like a
good idea. I'll have a closer look tomorrow, and should be able to get a
new release out by the end of the week.
—
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABP5MH5V7FUXZ2NL4HV6Y32AG7PNAVCNFSM6AAAAABROU3CKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZHE2TCMRUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@camillol I've just released 1.9.1 with this change - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrapping a file object, if it raises an exception upon read, it currently gets entirely overwritten by the ZranError raised by IndexedGzipFile. With this change, the original exception will be preserved as the cause of the ZranError.
The original exception can contain important information, and with this it will be included in the traceback.