Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

fix(umd): add json plugin #31

Merged
merged 1 commit into from
Apr 7, 2017
Merged

fix(umd): add json plugin #31

merged 1 commit into from
Apr 7, 2017

Conversation

kentcdodds
Copy link
Contributor

@kentcdodds kentcdodds commented Apr 7, 2017

What: This adds rollup-plugin-json

Why: Because we broke the rollup build when we started requiring packages that use main as a json file 😄

How: add the plugin, also refactor things a little bit to be cleaner.

cc: @tsriram

@kentcdodds kentcdodds added the bug label Apr 7, 2017
@kentcdodds kentcdodds requested a review from paulmolluzzo April 7, 2017 21:24
@codecov-io
Copy link

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      3    +1     
  Lines          64     62    -2     
  Branches        9      9           
=====================================
- Hits           64     62    -2
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/dom-elements.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1293859...68dd350. Read the comment docs.

@kentcdodds
Copy link
Contributor Author

I added a PR to fix the dependency ci issue: rollup/rollup-plugin-json#25

kentcdodds referenced this pull request Apr 7, 2017
With this inclusion git will attempt to keep multiple changes to a README to avoid conflicts

BREAKING CHANGE: none

none
@kentcdodds kentcdodds merged commit 47c26e0 into master Apr 7, 2017
@kentcdodds kentcdodds deleted the pr/fix-umd branch April 7, 2017 21:38
@kentcdodds
Copy link
Contributor Author

Merging this as-is considering it's breaking anyone using the UMD build via unpkg.com (like my intro blogpost 😉)

Feel free to still review and we can address any needed changes.

@paulmolluzzo
Copy link
Collaborator

I'll review tonight.

Merging this as-is considering it's breaking anyone using the UMD build via unpkg.com (like my intro blogpost 😉)

🙈

Copy link
Collaborator

@paulmolluzzo paulmolluzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I ran npm start validate ✅ and I installed 2.0.1 from npm in a test project ✅ .

Quick fix! 👏 Just that all PRs are going to fail until your PR for the dependency is merged.

@tsriram
Copy link
Contributor

tsriram commented Apr 10, 2017

So npm start validate is supposed to fail without this change?

@kentcdodds
Copy link
Contributor Author

No, npm start validate wont fail based on the UMD build. Though we could make it do that like I do in match-sorter with the dist-test. Not a bad idea actually...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants