-
Notifications
You must be signed in to change notification settings - Fork 207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 3 +1
Lines 64 62 -2
Branches 9 9
=====================================
- Hits 64 62 -2
Continue to review full report at Codecov.
|
I added a PR to fix the dependency ci issue: rollup/rollup-plugin-json#25 |
With this inclusion git will attempt to keep multiple changes to a README to avoid conflicts BREAKING CHANGE: none none
Merging this as-is considering it's breaking anyone using the UMD build via unpkg.com (like my intro blogpost 😉) Feel free to still review and we can address any needed changes. |
I'll review tonight.
🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I ran npm start validate
✅ and I installed 2.0.1
from npm in a test project ✅ .
Quick fix! 👏 Just that all PRs are going to fail until your PR for the dependency is merged.
So |
No, |
What: This adds
rollup-plugin-json
Why: Because we broke the rollup build when we started requiring packages that use
main
as ajson
file 😄How: add the plugin, also refactor things a little bit to be cleaner.
cc: @tsriram