Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SQL comment highlighting in codefences #215

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

LockeBirdsey
Copy link
Contributor

Was sketching out some DB stuff and noticed SQL comments weren't supported in QOwnNotes.

This PR enables the following SQL comment styles to be used:

CREATE TABLE table ();
-- single line comments
SELECT * FROM table;
/* multi-
  line comments
*/
DELETE FROM table; /* strange usage of multiline comments */

It also prevents the use of // as they aren't supported in SQL

@pbek
Copy link
Owner

pbek commented Feb 2, 2025

Thank you very much!

@pbek pbek merged commit 403ff95 into pbek:main Feb 2, 2025
1 check passed
pbek added a commit to pbek/QOwnNotes that referenced this pull request Feb 2, 2025
@pbek
Copy link
Owner

pbek commented Feb 2, 2025

Will be in the next release of QOwnNotes...

25.2.1

  • Support was added SQL comments in code blocks for the SQL syntax highlighter
    (for #215, thank you, @LockeBirdsey)

@pbek
Copy link
Owner

pbek commented Feb 2, 2025

There now is a new release, could you please test it and report if it works for you?

@LockeBirdsey
Copy link
Contributor Author

There now is a new release, could you please test it and report if it works for you?

Yep, it's working as intended

@pbek
Copy link
Owner

pbek commented Feb 3, 2025

Great, thank you for testing!

@LockeBirdsey LockeBirdsey deleted the addMissingSqlCommentHighlighting branch February 8, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants