♻️ Use getBlockTimestamp() for block.timestamp in vm.warp (#294)

### 🕓 Changelog This commit refactors `TimelockController.t.sol` to use `getBlockTimestamp()` instead of `block.timestamp`, as `block.timestamp` is assumed to be constant across a transaction and will be optimised out by the compiler. For more details, see [issue](foundry-rs/foundry#6180). Additionally, `solhint` has been upgraded to the latest version, [`v5.0.4`](https://github.com/protofire/solhint/releases/tag/v5.0.4), and all submodules have been updated to their most recent commits. --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
pcaversaccio · Jan 3, 2025 · 866a8f4 · 866a8f4
1 parent a242052
commit 866a8f4
Show file tree

Hide file tree

Showing 7 changed files with 508 additions and 503 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
diff --git a/.gas-snapshot-venom b/.gas-snapshot-venom
diff --git a/lib/create-util b/lib/create-util
diff --git a/lib/utils/VyperDeployer.sol b/lib/utils/VyperDeployer.sol
@@ -22,7 +22,7 @@ error DeploymentFailed(address emitter);
  * https://book.getfoundry.sh/cheatcodes/?highlight=CheatCodes#cheatcode-types)
  * in other test files without errors.
  */
-// solhint-disable-next-line contract-name-camelcase
+// solhint-disable-next-line contract-name-capwords
 interface _CheatCodes {
     function ffi(string[] calldata) external returns (bytes memory);
 }

diff --git a/package.json b/package.json
@@ -47,6 +47,6 @@
     "prettier": "^3.4.2",
     "prettier-plugin-sh": "^0.14.0",
     "prettier-plugin-solidity": "^1.4.1",
-    "solhint": "^5.0.3"
+    "solhint": "^5.0.4"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml