Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Add Base64 Encoding and Decoding Functions #47

Merged
merged 20 commits into from
Jan 5, 2023
Merged

💥 Add Base64 Encoding and Decoding Functions #47

merged 20 commits into from
Jan 5, 2023

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Jan 2, 2023 •
edited
Loading

🧙🏼‍♂️ CHANGELOG

Closes #45.

🧹 Chore

  • We cache the variable lengths to optimise for gas costs in ERC721, ECDSA, MerkleProofVerification, and SignatureChecker. Additionally, we rename leaves_len to leaves_length in MerkleProofVerification due to the sake of consistency.
  • We add the missing bool param in the function docstring of _exists in the ERC721 contract.
  • We add Paul's assertion library prb-test as a submodule since it supports equality assertions for arrays.

@pcaversaccio
❇️ start with Base64
e954317 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio added the feature 💥 New feature or request label Jan 2, 2023
@pcaversaccio pcaversaccio self-assigned this Jan 2, 2023
pcaversaccio and others added 10 commits January 2, 2023 11:24
@pcaversaccio
Merge branch 'main' into base64
bf66921
@pcaversaccio
♻️ cache length & naming
f85e9bb 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ first small version
7571864 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ small improvements
1359ef1 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
Merge branch 'main' into base64
b1bf77a
@pcaversaccio
Merge branch 'base64' of https://github.com/pcaversaccio/snekmate int…
778f7e4 
…o base64
@pcaversaccio
🫠 first working version of encoding
53d4b7c 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ test preparation
52363bf 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
forge install: prb-test
30e2818 
v0.3.1
@pcaversaccio
🥳 encoding functions running
118b95e 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio marked this pull request as ready for review January 3, 2023 16:32
@pcaversaccio pcaversaccio added the bug 🐛 Something isn't working label Jan 3, 2023
@pcaversaccio
♻️ formatting
25f5206 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ wording
c3fef15 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ comment on immutable bytes type
7a4cb92 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
🥳 decoding function is working
c01aaf3 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ prettier
61e181e 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
🖊 comments
e2d8569 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
🖊 further comments
922b29c 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
pcaversaccio
pcaversaccio commented Jan 4, 2023
View reviewed changes
Copy link
Owner Author

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for final feedback before merging.

@pcaversaccio
♻️ snapshot
cce05b5 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio
♻️ wording
362aa3a 
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio merged commit 87f4080 into main Jan 5, 2023
@pcaversaccio pcaversaccio deleted the base64 branch January 5, 2023 09:50
@pcaversaccio pcaversaccio added this to the 0.0.1 milestone Feb 1, 2023
@pcaversaccio pcaversaccio changed the title ❇️ Base64 Encoding and Decoding Functions 💥 Add Base64 Encoding and Decoding Functions Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcaversaccio pcaversaccio

Labels
bug 🐛 Something isn't working feature 💥 New feature or request
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.

💥 Base64 Util
1 participant
@pcaversaccio