-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
56 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Template for commit messages from Prettifier. | ||
# Placeholders are: | ||
# - {{commitSha}}: the SHA of your commit that Prettifier formats | ||
commitMessage: 'AutoFormat {{commitSha}}' | ||
|
||
fixByCommit: true | ||
|
||
fixByPullRequest: false | ||
|
||
prettified-message: > | ||
I have adjusted the formatting of this pull request for you. | ||
To stop seeing this message, please install Prettier on your machine and run | ||
`meteor npm run format` to format your changes before submitting them. | ||
# Whether to only check branches that have an active pull request. | ||
pulls-only: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: Unit tests | ||
|
||
on: | ||
push: | ||
branches: [ master ] | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js 16.x | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 16.x | ||
cache: 'npm' | ||
- run: npm i | ||
- name: Run tsc-check | ||
run: npm run tsc-check | ||
- name: Run tests | ||
run: npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,8 +12,9 @@ All notable changes will be documented in this file. | |
|
||
The main goals of the second version: | ||
|
||
- modernize the code base: use `es6` and latest tools | ||
- target to the latest browsers API(you can use webrtc adapter to shim old browsers) | ||
- modernize the code base: use `es6` and latest tools; | ||
- target to the latest browsers API(you can use webrtc adapter to shim old browsers); | ||
- shrink the package size. | ||
|
||
### Breaking changes | ||
|
||
|
@@ -59,6 +60,16 @@ import Peer from 'peerjs/dist/peerjs.min.js'; | |
... | ||
``` | ||
|
||
#### Remove `dist` folder from git | ||
|
||
Please, try to host the package by yourself. It is more securely and you don't depend on third party. | ||
|
||
In any case, you can use a CDN like `unpkg.com`: | ||
|
||
```html | ||
<script src="https://unpkg.com/[email protected]/dist/peerjs.min.js"></script> | ||
``` | ||
|
||
#### Use `ESBuild` as bundler. | ||
|
||
Parcel 1 was a good choice years ago, but now esbuild seems like simple and good solution! | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters