feat(pd)!: migrate to cometbft v0.37 #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
had a problem deploying
to
smoke-test
GitHub Actions
Failure
conorsch
force-pushed
the
2263-cometbft-37
branch
from
9e8f2f7 to
59ae5f9
Compare
conorsch
had a problem deploying
to
smoke-test
GitHub Actions
Failure
conorsch
force-pushed
the
2263-cometbft-37
branch
from
59ae5f9 to
056dca0
Compare
conorsch
force-pushed
the
2263-cometbft-37
branch
from
056dca0 to
38eae04
Compare
erwanor
reviewed
Sep 29, 2023
| @@ -81,6 +81,10 @@ impl Consensus { | |||
| .await | |||
| .expect("commit must succeed"), | |||
| ), | |||
| // The proposal types were added in CometBFT v0.37.x. | |||
| // How should they be handled in narsil? | |||
There was a problem hiding this comment.
The same way as we do in the main application. This can be done later
Bumps the rust imports for tendermint-rs and tower-abci to use the v037, rather than v034, modules. The substantive change is the addition of two new ABCI event types: * PrepareProposal * ProcessProposal The consensus logic has been updated according to spec [0]. Refs #2263. [0] https://github.com/cometbft/cometbft/blob/v0.37.2/spec/abci/abci%2B%2B_comet_expected_behavior.md#adapting-existing-applications-that-use-abci
conorsch
force-pushed
the
2263-cometbft-37
branch
from
38eae04 to
16f4fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the rust imports for tendermint-rs and tower-abci to use the v037, rather than v034, modules. The substantive change is the addition of two new ABCI event types:
The consensus logic has been updated according to spec [0].
Refs #2263.
[0] https://github.com/cometbft/cometbft/blob/v0.37.2/spec/abci/abci%2B%2B_comet_expected_behavior.md#adapting-existing-applications-that-use-abci