-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account_group_id -> wallet #3145
Conversation
21435cf
to
d770829
Compare
One thing I don't think we settled on: up to this point, the "account group ID" has been a purely internal name, only used in internal code and datastructures. Adding a Bech32 prefix for it feels like making it in some sense user-facing (at least to a subset of users). Did we want to align on terminology first? We'd talked about having a conceptual hierarchy of "wallet" / "account" / "address" for spend capability / logical account / payment capability that we currently call "account group" / "account" / "address". Should we commit to that? |
6c4da0a
to
dda2b80
Compare
dda2b80
to
d7b2a6e
Compare
d7b2a6e
to
648cc51
Compare
@hdevalence I think that terminology makes sense! There also seemed to be consensus on the team meeting with it too. Changed all instances of account group id to wallet. |
I hate to ask to redo everything, but I'm wondering if we could call it |
648cc51
to
f7f1881
Compare
I wasn't sure if this struct would be something later down the line we'd extend. I had a hunch about Id though. Wasn't terribly hard to add. |
f7f1881
to
58df27d
Compare
58df27d
to
90e6246
Compare
@hdevalence thanks for the re-review 🙏 |
Closes ##2997