Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERA-1016 :: fix lint errors or make them more obvious with suppress #11

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

michaeltchuang
Copy link
Collaborator

@michaeltchuang michaeltchuang commented Oct 22, 2024

Pull Request Template

Description

  • Fix any lint issues that were simple to do
  • Add in suppress for lint errors so they are obvious and lint job can pass as initial baseline
  • I ignored lint warnings

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

Additional Notes

  • We can fixed the suppressed errors in future PRs since they are pre-existing. This PR will at least start with a baseline that the ./gradlew lint job will pass

@michaeltchuang michaeltchuang added the chore technical tasks label Oct 22, 2024
@michaeltchuang michaeltchuang self-assigned this Oct 22, 2024
@michaeltchuang michaeltchuang merged commit 81a7e63 into perawallet:dev Oct 23, 2024
2 of 3 checks passed
@michaeltchuang michaeltchuang deleted the chore/PERA-1016-lint branch October 23, 2024 02:10
@michaeltchuang michaeltchuang added this to the 5.11.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore technical tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants