Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Percy Playwright Dotnet Support #1

Merged
merged 19 commits into from
Jun 17, 2024
Merged

[Feat]: Percy Playwright Dotnet Support #1

merged 19 commits into from
Jun 17, 2024

Conversation

chinmay-browserstack
Copy link
Contributor

@chinmay-browserstack chinmay-browserstack commented Jun 12, 2024 •
edited
Loading

  • Added snapshot (web) and screenshot (PoA) commands
  • Added tests
  • Added workflow
  • Added readme

@chinmay-browserstack chinmay-browserstack requested review from a team, yashdsaraf and Amit3200 and removed request for a team June 13, 2024 18:53
@chinmay-browserstack chinmay-browserstack changed the title Added Screenshot and Snapshot command [Feat]: Percy Playwright Dotnet Support Jun 13, 2024
rishigupta1599
rishigupta1599 reviewed Jun 14, 2024
View reviewed changes
Amit3200
Amit3200 reviewed Jun 14, 2024
View reviewed changes
Amit3200
Amit3200 reviewed Jun 14, 2024
View reviewed changes
Amit3200
Amit3200 reviewed Jun 14, 2024
View reviewed changes
Amit3200
Amit3200 reviewed Jun 14, 2024
View reviewed changes
Amit3200
Amit3200 requested changes Jun 14, 2024
View reviewed changes
Copy link

@Amit3200 Amit3200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update links and readme

Amit3200
Amit3200 reviewed Jun 14, 2024
View reviewed changes
Percy/Percy.csproj Outdated
<PackageId>PercyIO.Playwright</PackageId>
<Description>Percy for Playwright Driver API .NET Bindings</Description>
<PackageTags>playwright;percy;visual;testing</PackageTags>
<Version>1.0.0</Version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are targeting beta first.

@chinmay-browserstack chinmay-browserstack enabled auto-merge (squash) June 17, 2024 13:54
@Amit3200 Amit3200 disabled auto-merge June 17, 2024 13:55
@Amit3200 Amit3200 merged commit 730804a into main Jun 17, 2024
1 of 2 checks passed
@Amit3200 Amit3200 deleted the intial_implementation branch June 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishigupta1599 rishigupta1599 rishigupta1599 left review comments

@Amit3200 Amit3200 Amit3200 approved these changes

@yashdsaraf yashdsaraf Awaiting requested review from yashdsaraf yashdsaraf was automatically assigned from percy/percy-platform-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinmay-browserstack @Amit3200 @rishigupta1599