Bugfix for validator bond updating #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeet97
reviewed
Aug 10, 2023
…d accounting c571075 - increment validator bond shares in cancel unbonding 846943c - increased validator bond shares during redelegation 3024452 - removed validator pointer from liquid staking accounting functions 04843f4 - moved removal of tokenize share locks outside of iterator 8f4c9dc - fixed test + 2 new tests
kruspy
approved these changes
Aug 24, 2023
| if delegation.ValidatorBond { | ||
| if err := k.SafelyDecreaseValidatorBond(ctx, &srcValidator, srcShares); err != nil { | ||
| // If this is a validator self-bond, the new liquid delegation cannot fall below the self-bond * bond factor | ||
| // The delegation on the new validator will not a validator bond |
ajeet97
pushed a commit
that referenced
this pull request
Mar 20, 2024
Bugfix for validator bond updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New logic from upstream that ensures increased validator bond shares during delegation.
This allows to increase delegation after marking previous delegation as bond, thus allowing to LSM-tokenize more.
Test is in this PR:
persistenceOne/persistenceCore#225
Upstream changes:
iqlusioninc#24